open-telemetry / open-telemetry/opentelemetry-cpp
Set OPENTELEMETRY_BUILD_IMPORT_DLL as interface definition of the Windows DLL target opentelemetry_cpp
Open
Nobody has claimed this yet.
bug
Stale
triage/accepted
- Dominant language
- C++
- Stars
- 1.4k
- Forks
- 632
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 75
Description
Tracking the follow-up for below comment, and it will remove the requirement on user to define it manually, and utilize CMake to propagate it from the DLL target automatically.
https://github.com/open-telemetry/opentelemetry-cpp/pull/3421#pullrequestreview-2849787531
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the referenced pull request review and locating the CMake definition of the Windows DLL target opentelemetry_cpp. Confirm how OPENTELEMETRY_BUILD_IMPORT_DLL is currently expected to be provided, then verify that the target propagates it automatically as an interface definition without manual user configuration.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cmake, cpp
- Domain
- build-system
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100