open-telemetry / open-telemetry/opentelemetry-cpp

Test BasicCurlHttpTests.FinishInAsyncCallback is unstable in CI.

Open
#3,172 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug Stale triage/accepted
Dominant language
C++
Stars
1.4k
Forks
632
Avg merge
1d 13h
Merged PRs (30d)
75

Description

[ RUN      ] BasicCurlHttpTests.FinishInAsyncCallback
ext/test/http/curl_http_test.cc:525: Failure
Value of: handlers[i]->got_response_
  Actual: false
Expected: true

[  FAILED  ] BasicCurlHttpTests.FinishInAsyncCallback (5 ms)
[----------] 15 tests from BasicCurlHttpTests (7643 ms total)

[----------] Global test environment tear-down
[==========] 15 tests from 1 test suite ran. (7643 ms total)
[  PASSED  ] 14 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] BasicCurlHttpTests.FinishInAsyncCallback

 1 FAILED TEST
===========================================================================

To investigate, unclear if this is a failure due to the test itself, or the production code tested.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read ext/test/http/curl_http_test.cc around line 525 and inspect BasicCurlHttpTests.FinishInAsyncCallback. First reproduce the CI failure and trace whether the test or the production code causes handlers[i]->got_response_ to remain false. Done means identifying the cause and making the test reliable or correcting the responsible code.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
networking, testing-qa
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.