open-telemetry / open-telemetry/opentelemetry-cpp

Inconsistency between Bazel & CMake

Open
#2,072 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug do-not-stale good first issue help wanted
Dominant language
C++
Stars
1.4k
Forks
632
Avg merge
1d 13h
Merged PRs (30d)
75

Description

Describe your environment In OTLP project, there are two different build mechanisms which one of them could be used for compilation different targets. Also, it would be helpful to maintain different third party packages from their source codes.

Steps to reproduce
For CMake, there is a file(third_party_release) which contains which third party library is linked with which version. Same for Bazel, the file(repository.bzl) contains same information. However, both file contains different third-party versions as an information.

For example;

  • benchmark=v1.5.3 was defined for CMake but for Bazel it was defined "benchmark-1.6.0".
  • CURL library was not defined as a depedency in the CMake.

What is the expected behavior?
Same versions must be used for even different build mechanisms.

What is the actual behavior?
There are different versions for Bazel and CMake which could cause inconsistency.

Additional context
Add any other context about the problem here.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Compare the third_party_release file used by CMake with repository.bzl used by Bazel, starting with the benchmark versions and the CURL dependency mentioned in the issue. Done means the third-party dependency versions and declared dependencies are consistent between both build mechanisms.

Written by the indexing model from the issue text.

Assessment

Tech stack
cmake, cpp
Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.