open-telemetry / open-telemetry/opentelemetry-cpp
[CMake Build] Install necessary header files only?
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 1.4k
- Forks
- 632
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 75
Description
Follow up for https://github.com/open-telemetry/opentelemetry-cpp/pull/1932#issuecomment-1426604348
we install all headers when we run cmake --install now.In my understanding, is it better to select a subset of headers to install(all exported classes and their dependencies). Maybe we can also improve it in another PR.
For cmake, we install header files as below, @owent, do you think we should list the files to install explicitly instead of relying on pattern with wildcard?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the installation rules in api/CMakeLists.txt around lines 24–29 and review the linked pull request discussion. Determine which exported headers and dependencies should be installed and whether the current wildcard should be replaced with an explicit list. Done means cmake --install installs the intended public headers without unnecessary files.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cmake, cpp
- Domain
- build-system
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100