open-telemetry / open-telemetry/opentelemetry-cpp
Allow creation of AttributeValue from nostd::span<const char*>
@lalitb is already working on this.
Since Jun 1, 2022.
- Dominant language
- C++
- Stars
- 1.4k
- Forks
- 632
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 75
Description
Is your feature request related to a problem?
For debugging purposes I would like to add current callstack as an attribute to a span. backtrace_symbols returns char**, so I would like to use it directly and pass to span->SetAttribute(...), wrapped in nostd::span<const char*>. Now this is not possible, AttributeValue cannot be created from nostd::span<const char*>.
Describe the solution you'd like
Allow creation of AttributeValue from nostd::span<const char*>.
Describe alternatives you've considered
Now I need to create extra std::vector<opentelemetry::nostd::string_view> as a workaround.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.