open-telemetry / open-telemetry/opentelemetry-cpp
Remove curl dependency for Windows platform - Adding support for WinINet API
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 1.4k
- Forks
- 632
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 75
Description
Windows comes with WinINet API to enable applications to interact with FTP and HTTP protocols to access Internet resources. This means it doesn't explicitly need to use curl as an HTTP client library.
otel-cpp is designed to plugin any external client library by extending abstract classes defined in the ext::http::client namespace.
And HttpClientFactory factory is responsible to pick up the correct library based on the platform it is running.
CURL implementation is available here: https://github.com/open-telemetry/opentelemetry-cpp/tree/main/ext/include/opentelemetry/ext/http/client/curl
Similar implementation needs to be provided to support WinINet API.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with ext/include/opentelemetry/ext/http/client/http_client.h to understand the abstract client interfaces, then compare the CURL implementation under ext/include/opentelemetry/ext/http/client/curl with ext/src/http/client/curl/http_client_factory_curl.cc. Done means a WinINet-based implementation is available and the factory selects it on Windows without requiring CURL.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- networking
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100