open-telemetry / open-telemetry/opentelemetry-cpp-contrib
Why does building opentelemetry-cpp-contrib/instrumentation/nginx requires NGINX_VERSION and downloading Nginx? Can I just specify Nginx source myself?
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 153
- Forks
- 184
- Avg merge
- 2d 9h
- Merged PRs (30d)
- 26
Description
It seems that to configure it it requires NGINX_VERSION to be supplied, which will download Nginx. I intent to build Nginx from source anyway to add other modules, which means I already have Nginx source downloaded. How can I configure it to use existing Nginx source?
Steps to reproduce
cmake -DNGINX_VERSION=1.26.0
What is the expected behavior?
Can point to existing Nginx source
What is the actual behavior?
It downloads Nginx source again
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the CMake configuration under instrumentation/nginx and reproduce the issue using cmake -DNGINX_VERSION=1.26.0. Trace how the NGINX_VERSION option triggers the source download. Done means the configuration can accept and use an existing Nginx source tree instead of downloading it again.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cmake, nginx
- Domain
- build-system
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100