open-telemetry / open-telemetry/opentelemetry-cpp-contrib
NginxModuleRequestHeaders and NginxModuleResponseHeaders are case sensitives
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 153
- Forks
- 184
- Avg merge
- 2d 9h
- Merged PRs (30d)
- 26
Description
We are using since a while otel-webserver-module for NGINX.
Is there a good reason why NginxModuleRequestHeaders and NginxModuleResponseHeaders are case sensitives?
HTTP 1.1 and 2.0 states in their RFCs that they are insensitive.
It would be nice to get it aligned with that. Or maybe a new flag to not break current behaviour. In our case we need to double define headers here due to this issue. Some 3rd parties are sending camel case headers. It has become an issue.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the NginxModuleRequestHeaders and NginxModuleResponseHeaders handling in the otel-webserver-module. Check how header names are compared and review the HTTP/1.1 and HTTP/2 requirements cited in the issue. Done means camel-case headers work without duplicate definitions, while preserving or explicitly resolving current behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- nginx
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100