open-telemetry / open-telemetry/opentelemetry-cpp-contrib
Nginx: Start new span with kind client before proxying request
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 153
- Forks
- 184
- Avg merge
- 2d 9h
- Merged PRs (30d)
- 26
Description
What is the expected behavior?
To my understanding remote call spans should have span.kind: client. Currently this module only creates one span with kind server.
What is the actual behavior?
Create additional span with span.kind: client before proxying request.
Additional context
This can cause issues for tools which try to render a service map Grafana Tempo metrics generator for example. Technically there are other means to detect remote calls but client server spans are meant to serve that purpose.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue identifies the Nginx instrumentation module and its proxying path, but names no files or tests. Start by locating where the existing server span is created before proxying; done means an additional client-kind span is created for the remote call and the relevant module tests or service-map behavior confirm the span relationship.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- nginx
- Domain
- observability
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100