open-telemetry / open-telemetry/opentelemetry-cpp-contrib

nginx: Configure custom resource attributes

Open
#232 1 comment 6 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
153
Forks
184
Avg merge
2d 9h
Merged PRs (30d)
26

Description

As a user I'd like to define custom resource attributes (like deployment.environment) with both the module directives as well as the config toml file.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with instrumentation/otel-webserver-module/src/nginx/ngx_http_opentelemetry_module.c, especially the module directives referenced in the issue, and compare it with instrumentation/nginx/test/conf/otel-nginx.toml. Check the existing nginx configuration tests first. Done means custom resource attributes can be defined through both nginx module directives and the TOML configuration.

Written by the indexing model from the issue text.

Assessment

Tech stack
nginx
Domain
observability-sre
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.