open-telemetry / open-telemetry/opentelemetry-cpp-contrib

build.gradle fix for Apache 2.4 in otel-webserver-module

Open
#176 9 comments 1 reaction 1 assignee View on GitHub

@kpratyus is already working on this.

Since Jun 24, 2022.

bug Webserver
Dominant language
Python
Stars
153
Forks
184
Avg merge
2d 9h
Merged PRs (30d)
26

Description

Hi

I was working with the webserver-module and compiling it to test it and found a problem.

#0 53.23 > Task :configureApache24 FAILED
#0 53.23 checking for chosen layout... Apache
#0 53.23 checking for working mkdir -p... yes
#0 53.23 checking for grep that handles long lines and -e... /bin/grep
#0 53.23 checking for egrep... /bin/grep -E
#0 53.23 checking build system type... x86_64-unknown-linux-gnu
#0 53.23 checking host system type... x86_64-unknown-linux-gnu
#0 53.23 checking target system type... x86_64-unknown-linux-gnu
#0 53.23 configure:
#0 53.23 configure: Configuring Apache Portable Runtime library...
#0 53.23 configure:
#0 53.23 configure: error: Bundled APR requested but not found at ./srclib/. Download and unpack the corresponding apr and apr-util packages to ./srclib/.
#0 53.33
#0 53.33 FAILURE: Build failed with an exception.
#0 53.33
#0 53.33 * What went wrong:
#0 53.33 Execution failed for task ':configureApache24'.
#0 53.33 > Process 'command './configure'' finished with non-zero exit value 1
#0 53.33
#0 53.33 * Try:
#0 53.33 Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
#0 53.33
#0 53.33 * Get more help at https://help.gradle.org
#0 53.33
#0 53.33 Deprecated Gradle features were used in this build, making it incompatible with Gradle 5.0.
#0 53.33 Use '--warning-mode all' to show the individual deprecation warnings.
#0 53.33 See https://docs.gradle.org/4.10.2/userguide/command_line_interface.html#sec:command_line_warnings
#0 53.33
#0 53.33 BUILD FAILED in 49s
#0 53.33 4 actionable tasks: 4 executed

The current build.gradle file can't compile Apache 2.4 in the webserver container. The APR dependencies are not copied.

I was able to fix it by just including "inputs.dir bundleAprSources" at the beginning of the task configureApache24. Maybe this can be added to the current graddle file.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.