open-source-parsers / open-source-parsers/jsoncpp
Use std::ostringstream for numeric formatting
Open
Nobody has claimed this yet.
bug
help wanted
- Dominant language
- C++
- Stars
- 8.9k
- Forks
- 2.7k
- Avg merge
- 31m
- Merged PRs (30d)
- 1
Description
We've had lots of problems with std::snprintf. E.g. #418.
As BillyGoto says:
Could we switch to std::ostringstream instead? Its numeric formatting is actually specified in terms of printf's output, and it's everywhere.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading issue #418 and locating the std::snprintf calls involved in numeric formatting. Determine the full set of affected paths and existing tests before changing them. Done means numeric formatting uses std::ostringstream consistently and the relevant test suite still passes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100