open-source-parsers / open-source-parsers/jsoncpp
Avoid setting global CMake directories
Open
Nobody has claimed this yet.
bug
build
- Dominant language
- C++
- Stars
- 8.9k
- Forks
- 2.7k
- Avg merge
- 31m
- Merged PRs (30d)
- 1
Description
In https://github.com/open-source-parsers/jsoncpp/commit/a4fb5db54389e618a4968a3feb7f20d5ce853232, global cmake variables were set. This causes problems when jsoncpp is built together with other libraries by one cmake call. This messes up variables that should not be set or would be used differently for other libraries.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting commit a4fb5db54389e618a4968a3feb7f20d5ce853232 and the CMake configuration it changed. Reproduce a combined CMake build with jsoncpp and another library, then verify that jsoncpp no longer changes directory variables globally.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cmake, cpp
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100