open-mmlab / open-mmlab/mmengine

[Feature] Default Sampler in Runner

Open
#1,391 2 comments 0 reactions 1 assignee View on GitHub

@YiyaoYang1 is already working on this.

Since Oct 25, 2023.

Dominant language
Python
Stars
1.5k
Forks
464
No merged PRs in 30d

Description

What is the feature?

在runner中未对默认sampler进行定义，当config文件的dataloader不含有sampler时，会自动设置sampler为None，使用torch Dataloader默认的sampler。在单卡时不会出现问题，在多卡时会使得每张卡中的训练数据一样，显示的Epoch数也会相应出现问题。
建议加入默认Sampler的设定。

见https://github.com/open-mmlab/mmengine/blob/6c5eebb823e3c9381d63fd0cd1873ed1bd9ee9de/mmengine/runner/runner.py#L1396C34-L1396C34

Any other context?

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.