open-feature / open-feature/python-sdk-contrib
Support async in OFREP provider
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 27
- Forks
- 33
- Avg merge
- 5h 7m
- Merged PRs (30d)
- 9
Description
Right now the OFREP provider uses requests, which means that it can only support sync APIs.
Would there be any willingness to move to using the httpx library for http requests rather than requests? It's API compatible so should be a straightforward port, and it would then become trivial to add support for async requests.
I've opened https://github.com/open-feature/python-sdk-contrib/pull/311 to show concretely what I'm proposing, though I'll note that that PR just shows the update to the OFREP provider file; it still needs updates to dependencies to add httpx, new/updated tests, etc., just want to get more confirmation before going further.
(I opened the PR because I implemented the provider in my internal code and if nothing else wanted to share.)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the OFREP provider file shown in PR #311, then inspect the dependency configuration and the provider's existing tests. Confirm the dependency changes, add or update tests for synchronous and asynchronous requests, and verify that the provider supports both before considering the work done.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- api
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100