open-feature / open-feature/php-sdk
Add `evaluation details` to `finally` hook stage
Open
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 43
- Forks
- 14
- Avg merge
- 4d 12h
- Merged PRs (30d)
- 4
Description
Add evaluation details to finally hook stage.
Notes
This breaks the signature of the finally stages based on this spec enhancement. It is not considered a breaking change to the SDK because hooks are marked as experimental in the spec, and the change has no impact on known hooks.
- finally(hookContext, hookHints)
+finally(hookContext, evaluationDetails, hookHints)
Acceptance criteria:
- finally hook stage modified
- associated tests
Follow ups:
- update contribs
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the implementation of the finally hook stage and its associated tests, then inspect how the stage signature is defined and used. Update the stage to include evaluationDetails, and consider the acceptance criteria complete when the related tests cover the new signature and pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100