open-feature / open-feature/java-sdk-contrib

fix!: opentelemetry-semconv-incubating bump renames feature_flag.provider_name attribute

Open Beginner friendly
#1,843 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
49
Forks
81
Avg merge
20h 3m
Merged PRs (30d)
6

Description

Summary

Bumping opentelemetry-semconv-incubating in hooks/open-telemetry from 1.28.0-alpha to 1.43.0-alpha renames the semantic convention attribute emitted by TracesHook:

  • Old: feature_flag.provider_name
  • New: feature_flag.provider.name

The FEATURE_FLAG_PROVIDER_NAME constant name is unchanged in the upstream library — only the string value it points to changes (underscore → dot). The hook code (OTelCommons.java) references the constant, not a literal, so no source change is needed there. Only hardcoded changes within TracesHookTest.java test file.

Why this is breaking

This is a silent, consumer-facing change: any existing dashboard, alert, or query in Datadog/Grafana/etc. built against the feature_flag.provider_name span attribute will stop matching once this ships, with no compile-time or runtime signal to the consumer.

hooks/open-telemetry is currently at 3.3.1 (1.0+), and per the org technical guidelines:

Efforts should be made to avoid breaking changes in 1.0+ artifacts... Please consult with a member of the TC before making breaking changes to a 1.0+ component.

Scope note

This issue/PR is scoped only to the pinned version bump and the one test-string fix. A separate follow-up PR will adopt newly-available semconv attributes (e.g. FEATURE_FLAG_RESULT_VARIANT) — intentionally not bundled here as more clarification and guidance is needed.

Ask

@beeme1mr @Kavindu-Dodan @thiyagu06 @toddbaert — as component owners for hooks/open-telemetry, could you direct/ share your thoughts on the changes I am proposing? This is actually my first time contributing so I want to make sure I follow best practices! Hope to hear from you all soon, thanks!

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with hooks/open-telemetry/pom.xml and TracesHookTest.java. Review the pinned opentelemetry-semconv-incubating version and the hardcoded provider-name attribute expectations; consult the component owners about the 1.0+ breaking change. Done means the version is bumped, the test strings match feature_flag.provider.name, and the relevant tests pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
build-system, observability, testing
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.