open-feature / open-feature/go-sdk

Consider breaking up primary interfaces, or not exporting them

Open
#409 1 comment 0 reactions 0 assignees View on GitHub
needs discussion v2
Dominant language
Go
Stars
249
Forks
61
Avg merge
2d 10h
Merged PRs (30d)
20

Description

> Remove (or unexport) certain identifiers (types, functions, methods, interfaces) that are unnecessary. For example, [openfeature.IEvaluation](https://pkg.go.dev/github.com/open-feature/go-sdk/openfeature#IEvaluation) or [openfeature.IClient](https://pkg.go.dev/github.com/open-feature/go-sdk/openfeature#IClient) should most definitely not make it into v2. We will want to be especially careful about which interfaces we are exporting. Those that are exported must be named appropriately (not like IClient or ifaceClient or ClientIface).

We need to discuss this further, but we should rethink how we expose these interfaces.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.