open-feature / open-feature/flagd

[BUG] flagd 0.12.9/8 too many arguments in call to m.cfg.MetricRecorder.HTTPAttributes

Open
#1,834 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug Needs Triage
Dominant language
Go
Stars
997
Forks
136
Avg merge
4d 8h
Merged PRs (30d)
11

Description

Observed behavior

While trying to upgrade from 0.12.1 to 0.12.9 we ran into the following error:

feature/flagd/flagd/pkg/service/middleware/metrics
../.go-cache/pkg/mod/github.com/open-feature/flagd/flagd@v0.12.9/pkg/service/middleware/metrics/http_metrics.go:71:3: too many arguments in call to m.cfg.MetricRecorder.HTTPAttributes
have (string, string, string, string, string)
want (string, string, string, string)
make[1]: *** [Makefile:312: install_flagd] Error 1
make: *** [Makefile:1096: build_cnm_go] Error 2

seems to be an intertnal mismatch between flagd and core packages unless I'm missing something

Expected Behavior

No response

Steps to reproduce

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Inspect flagd/pkg/service/middleware/metrics/http_metrics.go and the MetricRecorder.HTTPAttributes signature in the related core package to compare the argument counts. Reproduce the upgrade/build through the install_flagd and build_cnm_go Makefile targets; done means the flagd and core package versions compile together without the reported mismatch.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.