open-compass / open-compass/opencompass

[Bug] DO NOT Use relative import

Open
#1,703 2 comments 0 reactions 1 assignee View on GitHub

@MaiziXiao is already working on this.

Since Nov 20, 2024.

Dominant language
Python
Stars
7.5k
Forks
869
Avg merge
17h 52m
Merged PRs (30d)
13

Description

先决条件
问题类型

我正在使用官方支持的任务/模型/数据集进行评估。

环境

https://github.com/open-compass/opencompass/blob/main/opencompass/models/__init__.py

relative import caused wrong package import, you should use absolute import in such a complex project.

重现问题 - 代码/配置示例
from .accessory import LLaMA2AccessoryModel
重现问题 - 命令或脚本
from .accessory import LLaMA2AccessoryModel
重现问题 - 错误信息

relative import a outside module instead of opencompass.models.xxx

you should use absolute import

其他信息

change to

from opencompass.models.accessory import LLaMA2AccessoryModel

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.