open-cli-tools / open-cli-tools/concurrently

--kill-others --kill-signal=SIGINT exits process with code 1

Open
#521 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
7.9k
Forks
281
Avg merge
17h 12m
Merged PRs (30d)
1

Description

I don't know if this is a bug or a feature request or if I'm simply not understanding how to properly use this package.

  • Description:
    I'm trying to run a web server, then run some e2e tests. When the tests complete successfully, the web server process is ended with SIGTERM, causing NPM to think the tests failed.
    If I don't kill the web server, the task keeps running forever/times out.

I've tried concurrently --kill-others --kill-signal=SIGINT "start server" && "run e2e tests"
as well as concurrently --kill-others --success last "start server" && "run e2e tests"

  • Expected Behaviour:
    Processes exit with code 0, NPM thinks (rightfully) that tests pass.

  • Environment:
    In an Azure devOps pipeline running Linux 5.15.0-1074-azure,
    v18.20.5,
    Concurrently 9.1.0

  • Reproduction: A way to reproduce the issue
    concurrently --kill-others --kill-signal=SIGINT "start server" && "run e2e tests"
    or concurrently --kill-others --success last "start server" && "run e2e tests"

Would you be able to see whether I'm doing something wrong if this is a feature request or bug?
Many thanks.

Screenshot 2024-12-16 at 18 38 17

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running the reported concurrently commands with --kill-others, --kill-signal=SIGINT, and --success last on Linux. Trace the signal and exit-status handling for the server and e2e commands; done means successful tests terminate the server without causing the overall process or npm to exit with code 1.

Written by the indexing model from the issue text.

Assessment

Tech stack
node.js, typescript
Domain
cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.