Add assertions to controller smoke tests
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 1
- Forks
- 0
- Avg merge
- 9h 55m
- Merged PRs (30d)
- 25
Description
Replace the current no-error-only reconcile smoke tests for ClusterPool, ClusterLease, and ClusterInstance with assertions for their initial reconcile state. Cover status or finalizer changes in the existing controller test files.\n\nFiles: internal/controller/clusterpool_controller_test.go, internal/controller/clusterlease_controller_test.go, internal/controller/clusterinstance_controller_test.go
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the existing smoke tests in internal/controller/clusterpool_controller_test.go, internal/controller/clusterlease_controller_test.go, and internal/controller/clusterinstance_controller_test.go. Run the controller tests to understand the current no-error-only behavior, then add assertions for each resource's initial reconcile status or finalizer changes. Done means all three existing test files verify those changes rather than only successful reconciliation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- testing
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100