opdev / opdev/guestcluster

Remove duplicate kubeconfig rewrite and unused crc-agent TLS helpers

Open
#29 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

kind/cleanup priority/important-longterm
Dominant language
Go
Stars
1
Forks
0
Avg merge
9h 55m
Merged PRs (30d)
25

Description

Problem

cmd/crc-agent/main.go contains a map-based rewriteKubeconfigServer, while internal/resources/kubeconfig.go already provides the typed shared RewriteKubeconfigServer. The implementations differ: the agent copy silently skips malformed entries and does not clear insecure-skip-tls-verify, while the shared helper does.

cmd/crc-agent/tlsutil.go also contains unused CA, client-certificate, serving-certificate, and PEM helpers. Only TLSFromPEM is used, and it only wraps tls.X509KeyPair.

References

  • cmd/crc-agent/main.go:374-403
  • internal/resources/kubeconfig.go:51-68
  • cmd/crc-agent/tlsutil.go:52-202
  • cmd/crc-agent/clusterclient.go:72-74

Suggested direction

Use the shared kubeconfig rewrite and remove the local duplicate. Remove unused TLS helpers and private constants, or call tls.X509KeyPair directly. Preserve tests for insecure flags, file-based CA data, and empty or malformed cluster entries.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Compare cmd/crc-agent/main.go:374-403 with internal/resources/kubeconfig.go:51-68, then inspect the TLS helpers in cmd/crc-agent/tlsutil.go:52-202 and their use from cmd/crc-agent/clusterclient.go:72-74. Reuse the shared kubeconfig rewrite, remove the unused helpers or direct wrapper, and preserve coverage for insecure flags, file-based CA data, and empty or malformed cluster entries.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend, security
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
76/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.