ooni / ooni/probe

Update HTTP Invalid Request Line test to use properly CRLF

Open
#477 2 comments 0 reactions 1 assignee View on GitHub

@bassosimone is already working on this.

Since Feb 17, 2020.

data-quality methodology
Dominant language
No language data
Stars
920
Forks
150
PR merge metrics
No merged PRs in 30d

Description

Currently the HTTP Invalid Request Line uses LF+CR at the end of the request line instead of CR+LF as is the standard.

I would suggest we change the test implementation and relative test specification to send at the end of very line CR+LF+CR+LF (twice since the request is supposed to be terminated by a blank line).

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.