ooni / ooni/explorer

Examine usage of getDerivedStateFromProps and refactor if needed

Open
#341 0 comments 0 reactions 1 assignee View on GitHub

Nobody has claimed this yet.

chore
Dominant language
JavaScript
Stars
92
Forks
45
PR merge metrics
No merged PRs in 30d

Description

Related to this comment on #75.

As described in the blog titled 'You Probably Don't Need Derived State', the usage of getDerivedStateFromProps is prone to anti-patterns. We should examine if we made those mistakes (most likely we did) and correct them if needed.

Note: This might involve some considerable overhaul of some of the components in the country page.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.