Handle case confirmed: true & blocking: false
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 92
- Forks
- 45
- PR merge metrics
- No merged PRs in 30d
Description
As mentioned in: https://github.com/ooni/explorer/pull/239#issuecomment-519432493 there can be some cases in which the measurement is confirmed (because we see a blockpage), but the blocking test_key is set to false, maybe because the control request failed.
In these cases, currently, we don't show the reason for blocking under the website as we do for the others.
We should consider if we want to handle this case in a special way, perhaps by enriching the pipeline-side heuristics to also determine the blocking method.
An sample measurement for this is: https://explorer-beta.ooni.io/measurement/20190703T163625Z_AS8708_UwLHVRiAoYGcScetNQ2uobFjyawbW11oqw4ZMIN8qJEZEF41pX?input=http://www.slotland.com.
cc @FedericoCeratto
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.