ooni / ooni/devops

fastpath input URLs are not normalized

Open
#471 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
HCL
Stars
4
Forks
15
Avg merge
1h 50m
Merged PRs (30d)
4

Description

where tests use input as a URL, e.g. web_connectivity, URLs are not consistent: in some cases they omit a trailing /, or omit the scheme.

We should figure out how to normalize these so that e.g. https://x.com is normalized to https://x.com/. Where we accept input using FastAPI AnyURL validator, it normalizes the string representation to include the trailing /.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the fastpath inputs used by web_connectivity and compare their URL handling with the FastAPI AnyURL validator mentioned in the issue. Check how URLs without a scheme or trailing slash are represented, then verify that equivalent inputs consistently produce the expected normalized form, such as https://x.com/.

Written by the indexing model from the issue text.

Assessment

Tech stack
fastapi
Domain
api, backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.