ooni / ooni/backend

api: add extra validation to certain endpoints

Open
#620 0 comments 0 reactions 1 assignee View on GitHub

@FedericoCeratto is already working on this.

Since Oct 24, 2022.

backend feature
Dominant language
Python
Stars
61
Forks
33
Avg merge
3d 2h
Merged PRs (30d)
3

Description

While it doesn't have a direct security impact, it's still probably a good idea.

We should be validating the user supplied fields a bit more, in particular the list_measurement endpoints could benefit from validating probe_cc and category_code.

This was identified as part of a security audit and classified as info level severity (OON-01-007).

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.