ooni / ooni/backend

Measurements that don't exist in the API should return the 404 HTTP code

Open
#522 2 comments 0 reactions 1 assignee View on GitHub

@FedericoCeratto is already working on this.

Since Nov 24, 2021.

feature
Dominant language
Python
Stars
61
Forks
33
Avg merge
3d 2h
Merged PRs (30d)
3

Description

Currently if you do an HTTP GET on an explorer URL that does not exist such as:

https://explorer.ooni.org/measurement/20180111T032529Z_AS4761_2l16dMgzTvsYsM1MWNt0SgFcA7dJi7uUnJececc3Gvx-EF525tU\?input\=http://www.grindr.com/

you will get an HTTP 200 OK but the body response will say "Measurement not found". A small fix would be to return HTTP 404 in this instance instead. This would make mass-checking explorer URLs for accessibility much less network intensive (on both sides) than getting the full response and checking for a text pattern inside.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.