onsails / onsails/right-agent

Track upstream microsandbox first-secret TLS activation bug

Open
#181 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
35
Forks
4
Avg merge
17h 19m
Merged PRs (30d)
8

Description

Summary

Track the temporary Right Agent workaround for superradcompany/microsandbox#1422.

microsandbox 0.6.10 persists the first secret added through modify().secret(...).restart().apply() but leaves TLS interception disabled. Provider placeholders then reach upstream APIs without substitution.

Production impact

This broke provider migration/rotation for agents whose sandbox was created before credentials were re-entered:

  • TwitterAPI.IO returned authentication failures although the stored key was valid.
  • FAL appeared unset after dashboard rotation.
  • Sandbox inspection showed correct bindings and allowed hosts, but network.tls.enabled=false.

Live recovery confirmed:

  • stored Twitter and FAL values matched operator-supplied files without exposing the values;
  • TLS-enabled sandbox requests returned HTTP 200 for TwitterAPI.IO and FAL;
  • the riskoff sandbox data fingerprint was preserved through the recovery cutover;
  • riskoff-bot, MCP server, cloudflared, and Claude startup health were all healthy afterward.

Right Agent work

  • Vendor microsandbox 0.6.10 with a minimal patch in apply_secret_patch_to_config() that enables TLS when the resulting secret set is non-empty.
  • Keep dashboard rotation propagation and startup reconciliation tests.
  • Add real-microVM regression coverage for:
    • first secret added to an existing TLS-disabled sandbox;
    • TLS enabled in durable and active config;
    • placeholder remains guest-visible;
    • HTTPS substitution reaches a local TLS fixture;
    • second independent provider binding;
    • live value rotation;
    • filesystem sentinel survives restart-backed changes.

Exit criteria

  • Upstream releases a version containing the fix and equivalent regression coverage.
  • Right Agent upgrades the pinned microsandbox version.
  • Remove vendor/microsandbox and restore the registry dependency.
  • Full workspace and live provider contract tests pass against upstream.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading upstream microsandbox issue #1422 and the local vendor/microsandbox work around apply_secret_patch_to_config(). Review the existing dashboard rotation propagation and startup reconciliation tests before assessing the requested real-microVM coverage. Done means the upstream fix and regression coverage are released, Right Agent upgrades its pinned dependency, vendor/microsandbox is removed, and the specified workspace and provider tests pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
infrastructure, networking, security
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
28/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.