onnx / onnx/optimizer

[Pass request] Fuse Pad - Pooling (Avg/MaxPool)

Open
#54 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
834
Forks
109
Avg merge
6h 55m
Merged PRs (30d)
2

Description

This is not an issue but a feature request for adding a fuse_pad_into_pool optimizer pass.

Currently, 'nop' pad layer are removed by eliminate_nop_pad.
Also, pad layers before conv layers are fused by fuse_pad_into_conv.

It would be desirable to have the same behavior also for pooling layers (AveragePool, MaxPool):
i.e.: fusing pad layers before pool layers into the pool layer.

Aka adding a fuse_pad_into_pool optimizer pass.

If you prefer us to provide a pull request for this feature, let us know.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the existing eliminate_nop_pad and fuse_pad_into_conv optimizer passes and their tests or registration points. Compare how padding before AveragePool and MaxPool is represented, then add the corresponding fuse_pad_into_pool behavior. Done means padding before pooling is fused consistently without breaking existing optimizer tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.