NopDropout elimination replaces mask usage by input
Open
Nobody has claimed this yet.
bug
- Dominant language
- C++
- Stars
- 834
- Forks
- 109
- Avg merge
- 6h 55m
- Merged PRs (30d)
- 2
Description
In https://github.com/onnx/onnx/blob/ea694bf5cbccf34e08f36a8d9365d9011b72aeb4/onnx/optimizer/passes/eliminate_nop_dropout.h#L31 all outputs of the Dropout layer are replaced with inputs. However the 2nd output of that layer is mask which shall contain the mask. In the NoOp case this is all 1s and NOT the input
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with onnx/optimizer/passes/eliminate_nop_dropout.h at the referenced line and review issue #1672 for the intended NoOp Dropout behavior. Check how the pass handles each Dropout output and verify that the mask output has the required all-ones value rather than the input.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100