onflow / onflow/flowkit

[BUG] Environment variables are validated when loading configuration

Open
#50 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
8
Forks
11
Avg merge
5d 59m
Merged PRs (30d)
1

Description

Current Behavior

Currently, if an environment variable is not found when loading a flowkit configuration, it will cause the config validation to fail. This is problemmatic behaviour for the Cadence Language Server, because it will not have these environment variables, so loading the config fails and it effectively makes it impossible to use the LS with environment variable keys.

Expected Behavior

Don't validate environment variables, maybe this could happen when the key is actually attempted to be used instead.

Steps To Reproduce

Try to use the Cadence Language Server with env var keys, VSCode will show an error.

Environment
n/a
What are you currently working on that this is blocking?

No response

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue by loading a flowkit configuration with an environment-variable key through the Cadence Language Server, then trace the configuration loading and validation entry points. Done means missing environment variables no longer make configuration loading fail, while validation happens when the key is used.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.