onflow / onflow/flowkit

[BUG] deploy does no longer create empty accounts

Open
#109 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
8
Forks
11
Avg merge
5d 59m
Merged PRs (30d)
1

Description

Current Behavior

Using the following flow.json

  "emulators": {
    "default": {
      "port": 3569,
      "serviceAccount": "emulator-account"
    }
  },
  "contracts": {
    "Debug": "./contracts/Debug.cdc",
    "FlowToken": {
      "source": "./contracts/FlowToken.cdc",
      "aliases": {
        "emulator": "0x0ae53cb6e3f42a79",
        "testnet": "0x7e60df042a9c0868",
        "mainnet": "0x1654653399040a61"
      }
    },
    "FungibleToken": {
      "source": "./contracts/FungibleToken.cdc",
      "aliases": {
        "emulator": "0xee82856bf20e2aa6",
        "testnet": "0x9a0766d93b6608b7",
        "mainnet": "0xf233dcee88fe0abe"
      }
    },
    "NonFungibleToken": {
      "source": "./contracts/NonFungibleToken.cdc",
      "aliases": {
        "testnet": "0x631e88ae7f1d7c20",
        "mainnet": "0x1d7e57aa55817448",
        "emulator": "0xf8d6e0586b0a20c7"
      }
    },
    "MetadataViews": {
      "source": "./contracts/MetadataViews.cdc",
      "aliases": {
        "testnet": "0x631e88ae7f1d7c20",
        "mainnet": "0x1d7e57aa55817448",
        "emulator": "0xf8d6e0586b0a20c7"
      }
    },
    "ViewResolver": {
      "source": "./contracts/ViewResolver.cdc",
      "aliases": {
        "testnet": "0x631e88ae7f1d7c20",
        "mainnet": "0x1d7e57aa55817448",
        "emulator": "0xf8d6e0586b0a20c7"
      }
    }
  },
  "networks": {
    "emulator": "127.0.0.1:3569",
    "mainnet": "access.mainnet.nodes.onflow.org:9000",
    "testnet": "access.devnet.nodes.onflow.org:9000"
  },
  "accounts": {
    "emulator-account": {
      "address": "f8d6e0586b0a20c7",
      "key": "dc0097a6b58533e56af78c955e7b0c0f386b5f44f22b75c390beab7fcb1af13f"
    },
    "emulator-first": {
      "address": "0x179b6b1cb6755e31",
      "key": "d5457a187e9642a8e49d4032b3b4f85c92da7202c79681d9302c6e444e7033a8"
    },
    "emulator-second": {
      "address": "0xf3fcd2c1a78f5eee",
      "key": "d5457a187e9642a8e49d4032b3b4f85c92da7202c79681d9302c6e444e7033a8"
    },
    "emulator-3": {
      "address": "0xe03daebed8ca0615",
      "key": "d5457a187e9642a8e49d4032b3b4f85c92da7202c79681d9302c6e444e7033a8"
    },
    "emulator-4": {
      "address": "0x045a1763c93006ca",
      "key": "d5457a187e9642a8e49d4032b3b4f85c92da7202c79681d9302c6e444e7033a8"
    }
  },
  "deployments": {
    "emulator": {
      "emulator-account": [],
      "emulator-first": [
        "Debug"
      ],
      "emulator-second": []
    },
    "testnet": {
      "emulator-first": [
        "Debug"
      ]
    },
    "mainnet": {
      "emulator-second": [
        "Debug"
      ]
    }
  }
}```

Debug.cdc here can just be an very simple contract. I have one in overflow repo. 

When i run 
```flow emulator -v```
and ```flow deploy``` this fails with

Deploying 1 contracts for accounts: emulator-account,emulator-first,emulator-second

❌ Failed to deploy contract Debug: failed to deploy contract Debug: failed to get account with address 179b6b1cb6755e31: client: rpc error: code = Internal desc = rpc error: code = NotFound desc = could not find account with address 179b6b1cb6755e31
❌ Command Error: failed deploying all contracts


### Expected Behavior

Flow cli should create the missing account like it used to

### Steps To Reproduce

1. create a new flow project
2. add a contract to the first available account 0x179b6b1cb6755e31
3. start emulator and run deploy

### Environment

```markdown
- OS: mac os x sonoma
- flow-cli: v2.2.11
What are you currently working on that this is blocking?

Upgrading find infrastructure to support new parsing syntax.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the flow deploy path and reproduce the failure using the flow.json configuration, flow emulator -v, and flow deploy commands described here. Trace how the listed accounts are handled when deployments contain an empty contract list. Done means deploy creates missing accounts such as emulator-first and proceeds with the Debug contract deployment.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.