onflow / onflow/flow

[REST] API client is sending in the block ids in the incorrect format

Open
#698 1 comment 0 reactions 1 assignee View on GitHub

@vishalchangrani is already working on this.

Since Nov 19, 2021.

bug Feedback
Dominant language
Go
Stars
361
Forks
159
PR merge metrics
No merged PRs in 30d

Description

Instructions

The Swagger Generated Go Client is sending the block ids in an incorrect format. It does a fmt.Sprintf("%v", id) for the id slice which causes the ids to be written out as [id1 id2 id3] etc. given how %v works for []string.

Current format

/v1/blocks/[id1 id1 id3...]

Correct format:

/v1/blocks/id1,id2,id3...

Problem

<what is the problem you've encountered?>

Steps to Reproduce

<share any logs/screenshots or steps to replicate>

Acceptance Criteria
Context

<what are you currently working on that this is blocking?>

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.