onflow / onflow/flow

Incorrect derivation path passed to the Ledger by Flow-Port when creating a Flow account

Open
#434 2 comments 4 reactions 1 assignee View on GitHub

@JeffreyDoyle is already working on this.

Since Dec 7, 2021.

Developer Tool Team
Dominant language
Go
Stars
361
Forks
159
PR merge metrics
No merged PRs in 30d

Description

When I create a Flow account using Flow Port ( https://port.onflow.org/ ) connected to the Ledger device, the derivation path displayed by the Flow app on the ledger device display is m/44'/1'/769/0/0 .

This derivation path looks very wrong on many levels (1' means BTC-testnet, the account number 769??, no hardened derivation for the account number etc).

My understanding is that the correct derivation path for Flow accounts should be m/44'/539'/x'/0/0 where x is the account number.

This incorrect derivation path could cause the Flow accounts derived from it to become stranded / un-reachable when the issue is fixed in Flow-Port, unless some code is implemented to look for already existing accounts previously created with this funky/wrong derivation path.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.