onflow / onflow/flow

Move BFT insecure code to BFTune repo

Open
#1,552 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Feature Feedback
Dominant language
Go
Stars
361
Forks
159
PR merge metrics
No merged PRs in 30d

Description

Issue To Be Solved

The code inside https://github.com/onflow/flow-go/tree/master/insecure is part of the BFT testing framework, BFTune. This code was meant to stand in a separate BFTune repository. The insecure code introduces vulnerabilities in Flow in order to make it more testable for different attack scenarios. The original plan was to move this code out to a separate repository and then consume it within flow-go. That way, flow-go doesn't have vulnerabilities baked into the code that were only meant for testing environments.

Suggest A Solution

@thep2p and @gomisha volunteer to:

References

BFT Testing Framework for Flow Blockchain - Conference Paper
BFTune: BFT Testing Framework for Flow Blockchain - Blockchain '23 Congress - Presentation on YouTube

cc @peterargue @vishalchangrani @Kay-Zee @AlexHentschel @dete

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing flow-go's insecure/ directory and integration/tests/bft, then compare the BFTune repository structure and integration points. Confirm how the Flow integration tests consume this code. Done means the insecure code and BFT integration tests reside in BFTune and all Flow integration tests still pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
blockchain, distributed-systems, security, testing-qa
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.