onflow / onflow/flow

Http API docs: Make it more clear which part of TransactionSignature must be Base64 encoded

Open
#1,016 0 comments 0 reactions 1 assignee View on GitHub

@10thfloor is already working on this.

Since Jun 29, 2022.

Document Feedback
Dominant language
Go
Stars
361
Forks
159
No merged PRs in 30d

Description

In the "Submit a transaction" request section, payload_signatures and envelope_signatures have the description "A list of Base64 encoded signatures". I'd suggest moving "Base64 encoded" to the description of "signature" inside the array of TransactionSignatures, as this is the property that actually needs to be Base64 encoded.

image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.