onflow / onflow/flow-go-sdk

GetExecutionResultForBlockID uses wrong query param

Open
#486 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
213
Forks
82
Avg merge
5d 59m
Merged PRs (30d)
1

Description

Problem

the access http.Client sets block_ids query param for GetExecutionResultForBlockID while the API spec uses block_id

This results in an error when calling the method with any block id

get execution results by IDs [df38d976b13ccfc40a379b1c779ee1ec2a4fb005b2dcb1bbc1ad823167cf8e3e] failed: no block IDs provided

Steps to Reproduce
resp, err := client.GetExecutionResultForBlockID(ctx, block.ID)
if err != nil {
	log.Fatal(err)
}

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in access/http/handler.go around line 401 and compare GetExecutionResultForBlockID with the parameter defined in the linked access API specification. Correct the query parameter used by the method, then verify the provided reproduction succeeds for a block ID without the “no block IDs provided” error.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
api
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.