onflow / onflow/flow-core-contracts
Replace `while` loop with `for` loop once references are allowed
Open
@SupunS is already working on this.
Since Sep 22, 2023.
SC-Eng
Technical Debt
- Dominant language
- Cadence
- Stars
- 93
- Forks
- 53
- PR merge metrics
- No merged PRs in 30d
Description
Issue To Be Solved
As discussed in https://github.com/onflow/flow-core-contracts/pull/382#discussion_r1326255239, The code had to be rewritten using a while loop, because references are not allowed in the for-loop.
Suggest A Solution
Revert this change once references are allowed to be used in for loop: https://github.com/onflow/cadence/issues/2784
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.