onflow / onflow/flow-core-contracts
Update all the transactions and scripts to use prepare/execute and post-conditions
Open
@joshuahannan is already working on this.
Since May 25, 2022.
documentation
Feedback
MoSCoW - Should
P-Medium
SC-Eng
Smart Contract
Technical Debt
- Dominant language
- Cadence
- Stars
- 93
- Forks
- 53
- PR merge metrics
- No merged PRs in 30d
Description
Issue To Be Solved
Many of the transactions in scripts to everything in the prepare block, which is against Cadence best practices
There are also opportunities to include post conditions in many of the transactions to ensure they executed properly
Suggest A Solution
- Split all transactions into prepare/execute when possible
- Add post conditions where possible
- Add additional comments to scripts and transactions if they are not documented
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.