onflow / onflow/flow-core-contracts
[DKG whiteboard] Restriction on broadcast
Open
@joshuahannan is already working on this.
Since Mar 24, 2022.
Needs Estimation
SC-Eng
- Dominant language
- Cadence
- Stars
- 93
- Forks
- 53
- PR merge metrics
- No merged PRs in 30d
Description
Context
The contract allows participating nodes to broadcast as many and as long data as they want. This issue is about adding restrictions to the messages sent on the whiteboard to avoid malicious behaviour:
- restrict the size of messages sent to the whiteboard.
- restrict the number of submissions per node if possible (to discuss with @jordanschalm).
Definition of Done:
-
@tarakby
- Once the format of broadcast messages is updated, compute the possible sizes of broadcast messages (verification vector/complaint/complaint answer)
- Compute the number of broadcasts possible per node.
-
@joshuahannan
rename the contract file to FlowDKGWhiteboard to avoid the confusion of thinking we're implementing DKG logic on chain.Renaming is not possible, a clarifying comment will be added instead.- update the contract to only accept certain sizes of broadcasts to the whiteboard (this is not about the size of final submissions which seems to be checked already)
- [if confirmed] update the contract to accept a maximum number of broadcast per node per DGK instance.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.