onflow / onflow/flow-cli

Installation using go toolchain

Open
#878 5 comments 0 reactions 1 assignee View on GitHub

@devbugging is already working on this.

Since Feb 23, 2023.

Feedback Help wanted
Dominant language
Go
Stars
209
Forks
87
Avg merge
1d 17h
Merged PRs (30d)
3

Description

Issue To Be Solved

Enable install/update using go toolchain:

go install github.com/onflow/flow-cli/cmd/flow@latest
(Optional): Suggest A Solution

I opened a draft PR to demonstrate what wold need to be done here:

With that PR this already works: https://github.com/onflow/flow-cli/pull/877

> go install github.com/onflow/flow-cli/cmd/flow@f5ece204f6833075aeecddbda60711e184629102
go: downloading github.com/onflow/flow-cli v0.46.3-0.20230223123946-f5ece204f683
> which flow
/home/user/go/bin/flow

But there are 2 problems:

  1. flow version does not work
    flow version
    Version information unknown!
    
  2. using replace in go mods is not allowed for go install to work. see: https://utcc.utoronto.ca/~cks/space/blog/programming/GoInstallLimitation (It's terrible). This would mean there is an extra step during releases where the flowkit version in go.mod would be updated

I think problem 1. is fixable, but problem 2. will requires overhead (hopefully CI overhead).

If anyone else would like this feature, maybe this can get pushed along, but I'm not sure if anyone (besides me) would like to have this.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.