onflow / onflow/flow-cli

Usage of the global configuration should be explicit

Open
#379 3 comments 0 reactions 1 assignee View on GitHub

@chasefleming is already working on this.

Since Mar 30, 2023.

Feedback Improvement
Dominant language
Go
Stars
209
Forks
87
Avg merge
1d 17h
Merged PRs (30d)
3

Description

Issue To Be Solved

The concept of the global configuration was introduced to allow you to have some global values you would use in any location where you execute the CLI. You can generate such a configuration by using flow init --global and then the CLI always checks for a local configuration and if that is not found try to loads a global configuration. This happens automagically and not explicitly which can lead to some weird edge cases where the value from global config is taken but the user thinks it was taken from the local config which could be missing. The fallback should be explicit as it doesn't hurt the UX much in doing so, but it improves the potential confusion which does hurt the UX a lot. There are also some security concerns to keep in mind.

(Optional): Suggest A Solution

Make sure when you want to reference a global config the command should include a global flag: --global or shortcut -g. Without this flag, the global config should not be used. If the global config is used it shouldn't load the local config.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.