onflow / onflow/flow-cli

flow config add deployment should error on adding conflicts

Open
#2,119 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
209
Forks
87
Avg merge
1d 17h
Merged PRs (30d)
3

Description

Reported by: Brian Doyle (<@brian.doyle>)

Issue Description:

Instead of resulting in an error with flow project deploy when flow.json has deployments for the same contract on the same network with two different accounts, it should error when you attempt to add the deployment to the second account with flow config add deployment

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the flow config add deployment command and compare its validation with the behavior of flow project deploy. Done means adding a deployment for the same contract and network under a different account fails immediately with an error, rather than allowing the conflict until deployment.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
blockchain, cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.