onflow / onflow/flow-cli

Create account functionality is not consistent

Open
#1,346 1 comment 0 reactions 2 assignees View on GitHub

@ianthpun is already working on this.

Since Jan 16, 2024.

Dominant language
Go
Stars
209
Forks
87
Avg merge
1d 17h
Merged PRs (30d)
3

Description

flow accounts create --key ... does not add account to flow.json, if user adds an account using interactive mode the account gets added.

The flow-cli docs indicates that flow accounts create --key ... will update the flow.json. This is not the case.

Docs actually say this:
"In the above example, the flow.json file would look something like this: " ...

Need to update flow-cli or update the docs.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.