onflow / onflow/flow-cli

Progress loggers issues

Open
#1,022 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Bug Improvement
Dominant language
Go
Stars
209
Forks
87
Avg merge
1d 17h
Merged PRs (30d)
3

Description

Progress reporting should be avoided where possible (in some cases it provides value to CLI users seeing the progress).

There's a possible bug not stopping the progress https://github.com/onflow/flow-cli/blob/93b7336efceb00bf20b3039ca3694cec492ebff9/flowkit/flowkit.go#L310
All the progress reports should be revisited and make sure they can run nicely with multiple go routines.

The logger should support integration with popular go logging libraries (logrus, zap, zerolog).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at flowkit/flowkit.go around line 310, then trace the other progress reports and logger usage mentioned by the issue. Check how progress behaves across multiple goroutines and review the integration requirements for logrus, zap, and zerolog. Done means progress can stop reliably, concurrent reporting behaves cleanly, and the logger supports the requested libraries.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli, tooling
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.