onflow / onflow/crypto

Update `Equals` functions

Open
#4 0 comments 0 reactions 1 assignee View on GitHub

@tarakby is already working on this.

Since Dec 8, 2023.

documentation enhancement good first issue
Dominant language
Assembly
Stars
3
Forks
5
PR merge metrics
No merged PRs in 30d

Description

Issue to be solved

The current Equals functions for public keys and private keys make implicit assumptions about nil receivers and inputs.

Suggested Solution

The function should clarify the assumptions in the doc, and update the implementation accordingly.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.