onflow / onflow/crypto

add control flow integrity (cfi)

Open
#16 1 comment 0 reactions 1 assignee View on GitHub

@tarakby is already working on this.

Since Sep 5, 2024.

enhancement
Dominant language
Assembly
Stars
3
Forks
5
PR merge metrics
No merged PRs in 30d

Description

Issue to be solved

Add cfi in the C flags to protect the package against non intended code execution flows in the package.

CFI only available on clang and linux, and can be added by extending CFLAGS to include -fvisibility=hidden -flto -fsanitize=cfi.
The feature should be added only when building with clang on linux. Enforcing CFI for all usage of the package forces users to use clang which may add friction to importing the package.

original issue is https://github.com/onflow/flow-go/issues/3668.

Suggested Solution

No response

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.