onepub-dev / onepub-dev/reVault

review glob handling.

Open
#305 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
4
Forks
0
Avg merge
1h 55m
Merged PRs (30d)
1

Description

Need to have a look at how we are doing glob handlng for recursive opterations 'add -r *.txt'.

Also windows shell doesn't expand globs so I assume that means we need to on windows a maybe when a users does 'add -r "*.txt"'.

Discussion is required.

We can look at the dcli glob handling for some guidance.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the add -r command's glob handling for inputs such as *.txt and quoted "*.txt", comparing Unix shell expansion with Windows behavior. Review dcli's glob handling for guidance, then clarify the desired recursive and Windows behavior before implementation and testing.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
cli
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Needs clarification
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.